Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add ZLEXCOUNT command #2022

Merged

Conversation

acarbonetto
Copy link
Collaborator

Add command ZLEXCOUNT

@acarbonetto acarbonetto self-assigned this Jul 26, 2024
@acarbonetto acarbonetto requested a review from a team as a code owner July 26, 2024 15:50
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/TestUtilities.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Show resolved Hide resolved
node/src/Commands.ts Show resolved Hide resolved
Copy link
Collaborator

@aaron-congo aaron-congo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor nits, and agree with Yury that the enum InfScoreBoundary needs to be added to npm/glide/index.ts, otherwise LGTM

node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
@acarbonetto acarbonetto force-pushed the node/integ_acarbo_add_zlexcount_valkey-89 branch from 44b4fdd to 9e74986 Compare July 31, 2024 20:29
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the node/integ_acarbo_add_zlexcount_valkey-89 branch from 9e74986 to 469a1f4 Compare July 31, 2024 21:50
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto merged commit d785b95 into valkey-io:main Jul 31, 2024
8 checks passed
@acarbonetto acarbonetto deleted the node/integ_acarbo_add_zlexcount_valkey-89 branch July 31, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants